chore: fix konnect cleanup #6666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
added
the
area/maintenance
pmalek
force-pushed
the
fix-konnect-cleanup
branch
from
811f862 to
c1c59bf
Compare
czeslavo
approved these changes
Nov 13, 2024
pmalek
force-pushed
the
fix-konnect-cleanup
branch
from
c1c59bf to
0140da1
Compare
|
The compilation problem was caused by concurrent merges of two last PRs. Fix: #6667 |
pmalek
force-pushed
the
fix-konnect-cleanup
branch
from
0140da1 to
8165ba7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6666 +/- ##
=======================================
+ Coverage 77.6% 79.1% +1.4%
=======================================
Files 201 202 +1
Lines 23766 23748 -18
=======================================
+ Hits 18456 18790 +334
+ Misses 4359 4000 -359
- Partials 951 958 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Due to Kong/sdk-konnect-go#20 we need to set the URL for each operation that would hit the global endpoint. Otherwise we will get it overwritten with prod's global endpoint which we do not want.
Broke on CI: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/11819442161/job/32929360130#step:4:2832